[WIP] gh-151722: Defer GC tracking of frozendict.fromkeys() as possible#152021
Open
corona10 wants to merge 3 commits into
Open
[WIP] gh-151722: Defer GC tracking of frozendict.fromkeys() as possible#152021corona10 wants to merge 3 commits into
corona10 wants to merge 3 commits into
Conversation
Co-authored-by: tonghuaroot <tonghuaroot@gmail.com>
corona10
added
the
needs backport to 3.15
Member
Author
|
cc @tonghuaroot (I add you as the co-author), too many things need to be addressed from #151967 |
corona10
commented
Jun 23, 2026
| int status; | ||
|
|
||
| PyTypeObject *cls_type = _PyType_CAST(cls); | ||
| d = _PyObject_CallNoArgs(cls); |
Member
Author
There was a problem hiding this comment.
If there is a good way to obtain an untracked object here, that would be great, but I think that is a separate topic.
corona10
commented
Jun 23, 2026
| done: | ||
| // Built untracked above; GC-track now that it is complete. | ||
| if (d != NULL) { | ||
| assert(!_PyObject_GC_IS_TRACKED(d)); |
Member
Author
There was a problem hiding this comment.
@tonghuaroot
By this, we don't need additional test code.
corona10
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.