diagnostics_channel: capture console messages

[Qard]

I've added diagnostics_channel support to capture and modify inputs to the main console methods. This enables some useful things like APMs injecting tracing data into log messages to correlate log messages to the requests from which they originated. You can also replace the args list entirely, so you could apply your own custom formatting to produce JSON logs instead or things like that.

cc @nodejs/diagnostics @nodejs/console

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64088/

[eugeneo]

I lack context on this, so I might be missing some point.

Can this use the Inspector protocol instead of adding hooks directly into console object. In-process inspector API can be configured to watch for the messages? This way there will be less coupling.

[Qard]

The Inspector API is substantially more expensive. This is meant for being able to rewrite potentially all log messages in production, so it needs to be fast.

[eugeneo]

Thanks for the reply.

[Flarna]

Maybe worth to extend test to verify adding/removing/replacing elements,

Main problem I see with mutating diagnostics channels is the undefined sequence if there are more subscribers.

[Flarna]

Maybe describe that this is the arguments array and therefore mutation is possible.

[legendecas]

Would you mind rebasing on top of the main branch? The build failure should be fixed once rebased.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (f4fcf0e) to head (82b3ae5).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56292   +/-   ##
=======================================
  Coverage   89.19%   89.20%           
=======================================
  Files         662      662           
  Lines      191762   191791   +29     
  Branches    36907    36916    +9     
=======================================
+ Hits       171041   171079   +38     
+ Misses      13572    13558   -14     
- Partials     7149     7154    +5     

Files with missing lines	Coverage Δ
lib/internal/console/constructor.js	98.54% <100.00%> (+0.51%)	⬆️

... and 39 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64470/

[Qard]

Test are passing now. I'd appreciate some fresh approvals! 🙂

[nodejs-github-bot]

Landed in db7a31e