test: increase timeouts on arm#1366
Conversation
There was a problem hiding this comment.
This timeout seems to have been chosen too generous, so I reduced it.
|
@bnoordhuis could you start off a CI run with this PR? I need it to determine if the factors need more tweaking. |
|
Results are looking quite promising. I've rebased my branch to include silverwind@92ab3c0 which should fix two @bnoordhuis would appreciate another CI run! (also I think I messed up this PR with my last rebase) |
|
@silverwind You should probably sort out the rebase before I start another CI run, it looks like a wrong merge base now. |
3deca2c to
cb025c1
Compare
bd0f345 to
0c2210b
Compare
|
@bnoordhuis branch fixed. |
|
Quite satisfied so far. Results:
@bnoordhuis please review. |
There was a problem hiding this comment.
Minor style issue: function(ms)
|
Left some comments. |
|
In addition to above comments, I'll work on fixing that last timeout from |
8750c84 to
e4a5192
Compare
|
@bnoordhuis good for another CI run.
|
|
FYI, the persistent failure of parallel/test-debug-port-cluster on the ARMv8 machine was because there was a long running process there from a previous test run that was blocking the debug port that test was trying to use. I've killed that and now: So woohoo! I think this means we have solid ARMv8 support now doesn't it? I thought OpenSSL 1.0.2 was a blocker for us on ARMv8 but obviously that was addressed, by @bnoordhuis I guess. Unless anyone has a reason not to, I'm going to push forward trying to get some more server resources to figure out a release build strategy for ARMv8/AARCH64 binaries. |
|
@rvagg 🎉 nice, that means armv8 works pretty well already. While you're at the CI, I think the ARM bots could use some relabeling. You mentioned |
|
😄 Glad to see a blue light on armv8! Wait for a moment for ssl. |
|
Woops, I'll fix this. |
|
Sorry I missed the issue. I've just abort my job. So 472 will go on right now. |
|
@silverwind derp! I have an origial pi1 switched with the pi2 and they are reporting themselves as such, in the process of rectifying now |
|
Almost fully blue 😃 The @bnoordhuis please review so I can land this. |
|
LGTM |
|
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/473/ should be with the right machines running in the right place |
|
Looks |
|
Merged in 7049d7b |
|
@silverwind iirc, ccache is running on those machines, so it should be less than if you are running without. |
|
Little Pi still going strong after 7hrs: (I think it's safe to assume there's no cache involved here) |
|
it's because I changed the env of this and pi2 when you notified me they were around the wrong way - so the cache has to start again with new env vars influencing the build .. over time it should get much better |


Related: #1343
The static factors are still subject to change, and I think I'll look into benchmarking to obtain them dynamically. ARMv8 gets no special treatment as I think it won't need it. The ARMv6 factor is probably too low for some boards. My RPi does fine with around 2-3x, but it is overclocked and has a pretty fast SD.
If someone could start off a CI run with this PR, I'd be grateful as this should green out CI for ARMv6 and ARMv7.