http2 compat missing writableFinished

[ronag]

http2 compat is missing writableFinished for OutgoingMessage.

I tried fixing this myself but the whole finished flow for http2 compat confuses me.

• finished seems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).
• 'finish' is emitted on stream.on('close', ...).
• Sometimes we listen to this.on('finish', ...) and sometimes stream.on('finish', ...).

I think someone with a clearer understanding needs to look at this.

[ronag]

Slightly related #24347

[0hmX]

This is fixed as I test this on v25.0.0-pre

./node/out/Release/node ./node/test/parallel/test-test.js
1
/home/ohmx/Documents/node/test/parallel/test-test.js:30
    throw new Error('boom');
    ^

Error: boom
    at Domain.<anonymous> (/home/ohmx/Documents/node/test/parallel/test-test.js:30:11)
    at Domain.emit (node:events:507:28)
    at Domain.emit (node:domain:489:12)
    at Domain._errorHandler (node:domain:279:23)
    at Object.<anonymous> (node:domain:181:29)
    at process._fatalException (node:internal/process/execution:158:29)

Node.js v25.0.0-pre

[fru1tworld]

The writableFinished getter is implemented in lib/internal/http2/compat.js (line 554). I think this issue can be closed.

While checking, I noticed writableObjectMode and writableNeedDrain are still missing from Http2ServerResponse compared to http.OutgoingMessage. Filed #63000 to track that separately.

[trivikr]

Closing, as this issue was fixed in #33506