fs.createWriteStream TypeError with new io.js v2.3.0

[bricss]

karma-runner/karma#1454

[ChALkeR]

Could be related to: 353e26e 8357c50

@yosuke-furukawa

[ChALkeR]

I will test this later today.

[targos]

It is indeed related to 353e26e.

karma-html-reporter is using fs.createWriteStream with a callback, which is not supported and AFAIK has never been. This sudden error is uncovering a bug that needs to be fixed in the module.

[ChALkeR]

True.
https://iojs.org/api/fs.html#fs_fs_createwritestream_path_options says nothing about callbacks, so that's not supported.

[bricss]

Yep, they should fix this bug with close event.

[ChALkeR]

Still, it might be sensible to add a work-around for that on the io.js side.

[ChALkeR]

Some other places:

g/gist-backup-1.0.0.tgz/gist-backup.js:                    request(raw_url).pipe(fs.createWriteStream(dir + 'https://github.com/' + filename, function (error) {
m/mecano-0.4.1.tgz/lib/download.js:            return fs.createWriteStream(null, stageDestination, function(err, ws) {
m/mecano-0.4.1.tgz/lib/download.js:        return fs.createWriteStream(null, stageDestination, function(err, ws) {
m/mecano-0.4.1.tgz/lib/upload.js:        return fs.createWriteStream(options.ssh, options.destination, function(err, ws) {

[targos]

mecano is not using the fs module, but ssh2-fs instead. This library seems to accept a callback in createWriteStream

[ChALkeR]

Ah, ok. And for gist-backup I filed an issue.
Btw, that's not a full modules list.

[targos]

Btw, that's not a full modules list.

Yes I understand that, but anyway a module that is using a callback to check for error is wrong. It should listen for the error event, like with any stream.

[cjihrig]

We may want to revert 353e26e. It should have landed on the next branch, not master. It was also never properly signed off by anyone, even though the commit message says that I did.

[targos]

@cjihrig I agree. Even though it is wrong (and useless) to pass anything other than an object to these functions, it is still a breaking change.