fix: saving ckpt error when ckpt folder has some folder inside#3516
Merged
jb-ye merged 1 commit intoNov 8, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
save_only_latest_checkpointis True, it tried to delete everything in the chekpoint folder before saving the latest checkpoint.Since it is supposed that the
nerfstudio_modelsonly has checkpoint files inside, when there are some other customized saved folders inside, there will be an error.This change will list
*.ckptfiles only instead of everything (include folder) to be compared with latest checkpoint file before deleting.Thanks for your consideration