Send a CPR request on every unknown sequence#20009
Merged
Merged
Conversation
DHowett
reviewed
Mar 24, 2026
DHowett
reviewed
Mar 24, 2026
DHowett
left a comment
DHowett
left a comment
Member
There was a problem hiding this comment.
i'm fine with this, even if it's gonna be a little annoying to add a useless virtual dispatch in some places. eh.
it doesn't help with screen buffer consistency, but it does help with the user's input feeling like it's going in the right place i suppose.
| } | ||
| break; | ||
| } | ||
| case OscActionCodes::CurrentWorkingDirectory: |
Member
There was a problem hiding this comment.
clever, I see why you asked (and why you added this here too)
Member
Author
There was a problem hiding this comment.
Yeah, it was really annoying during testing lol.
DHowett
approved these changes
Mar 24, 2026
3 tasks
lhecker
added
Area-VT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is 90% wiring up OOP interfaces.
Closes #19926
Validation Steps Performed
github.com/xtermjs/vtcUnknownSequencecalls under a debugger