Improve UX for selection during VTMM#19973
Merged
Merged
Conversation
microsoft-github-policy-service
Bot
added
Issue-Task
DHowett
reviewed
Mar 16, 2026
DHowett
approved these changes
Mar 17, 2026
DHowett
pushed a commit
that referenced
this pull request
Apr 3, 2026
Selection in VT mouse mode has been feeling a little weird. I've made a few changes in this space to improve the overall experience when in vt mouse mode: - don't round selection positions: this means that you now highlight the cell you're on if you're going right, and the adjacent cell if you're going left - fix drag-left excluding the current cell - #9608: shift+click now clears any existing selection instead of extending it. This feels more intuitive since Shift already works as the override modifier Somewhat related to #18106 ## Validation ✅ alt selections feel consistent ✅ selecting in VTMM feels accurate (selects the cell we started on) ✅ creating new selections (aka clearing old selection) in VTMM feels intuitive (forwards and backwards) Closes #9608 (cherry picked from commit 2e33056) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgna3V8 Service-Version: 1.25
DHowett
pushed a commit
that referenced
this pull request
Apr 30, 2026
Selection in VT mouse mode has been feeling a little weird. I've made a few changes in this space to improve the overall experience when in vt mouse mode: - don't round selection positions: this means that you now highlight the cell you're on if you're going right, and the adjacent cell if you're going left - fix drag-left excluding the current cell - #9608: shift+click now clears any existing selection instead of extending it. This feels more intuitive since Shift already works as the override modifier Somewhat related to #18106 ## Validation ✅ alt selections feel consistent ✅ selecting in VTMM feels accurate (selects the cell we started on) ✅ creating new selections (aka clearing old selection) in VTMM feels intuitive (forwards and backwards) Closes #9608 (cherry picked from commit 2e33056) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgna3WE Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Selection in VT mouse mode has been feeling a little weird. I've made a few changes in this space to improve the overall experience when in vt mouse mode:
References and Relevant Issues
Somewhat related to #18106
Validation Steps Performed
✅ alt selections feel consistent
✅ selecting in VTMM feels accurate (selects the cell we started on)
✅ creating new selections (aka clearing old selection) in VTMM feels intuitive (forwards and backwards)
Closes #9608