Only honor Ctrl+Z during ReadFile if the console is in PROCESSED mode#19940
Merged
Conversation
This restores the behavior of ReadFile to that of Windows 7. Closes #4958
Member
Author
DHowett
commented
Mar 5, 2026
| // the behavior from Windows 7 (see filehops.c:123) we need to honor | ||
| // ^Z only if PROCESSED_INPUT is enabled. | ||
| ULONG InputMode{ 0 }; | ||
| m->_pApiRoutines->GetConsoleInputModeImpl(*pInputBuffer, InputMode); |
Member
Author
There was a problem hiding this comment.
This probably has a [[nodiscard]] hanging out on it
microsoft-github-policy-service
Bot
added
Issue-Bug
![github-advanced-security[bot]](https://avatars-githubusercontent-com.shimmerl.top/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
11 tasks
carlos-zamora
approved these changes
Mar 10, 2026
carlos-zamora
left a comment
carlos-zamora
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this. I took a look at your messages in #4958. Looks well thought out and complete!
lhecker
approved these changes
Mar 11, 2026
DHowett
added a commit
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the behavior of ReadFile to that of Windows 7.
Closes #4958