Skip to content

Fetch the terminal cursor position after a resize#19535

Merged
lhecker merged 4 commits into
mainfrom
dev/lhecker/18725-resize-cursor-position
Nov 18, 2025
Merged

Fetch the terminal cursor position after a resize#19535
lhecker merged 4 commits into
mainfrom
dev/lhecker/18725-resize-cursor-position

Conversation

@lhecker

@lhecker lhecker commented Nov 7, 2025

Copy link
Copy Markdown
Member

Closes #18725

Validation Steps Performed

Functionality was observed under a
debugger while using PowerShell 5.

github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 7, 2025
View reviewed changes
Comment thread src/host/VtIo.cpp Fixed
Comment thread src/host/VtIo.cpp Fixed
Comment thread src/host/VtIo.hpp Fixed
Comment thread src/host/screenInfo.cpp Fixed
@github-actions

This comment has been minimized.

Sign in to view
carlos-zamora
carlos-zamora approved these changes Nov 10, 2025
View reviewed changes

@carlos-zamora carlos-zamora left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks! 🙂

EDIT: aside from the build failure, of course. But that looks like it may be an easy fix.

Comment thread src/host/VtIo.cpp
// wait for the DA1 response below and effectively wait for both.
if (_lookingForCursorPosition)
{
writer.WriteUTF8("\x1b[6n"); // Cursor Position Report (DSR CPR)

@carlos-zamora carlos-zamora Nov 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝Moved to WriteDSRCPR()

@lhecker lhecker enabled auto-merge (squash) November 18, 2025 19:12
@lhecker lhecker merged commit 898b9e3 into main Nov 18, 2025
19 checks passed
@lhecker lhecker moved this to To Cherry Pick in Inbox Servicing Pipeline Nov 18, 2025
@lhecker lhecker deleted the dev/lhecker/18725-resize-cursor-position branch November 18, 2025 21:06
@lhecker

lhecker commented Nov 18, 2025

Copy link
Copy Markdown
Member Author

Market as Inbox Servicing Pipeline not for inbox, but for packaging as a nuget.

@DHowett DHowett mentioned this pull request Dec 3, 2025
Closed
@DHowett DHowett mentioned this pull request Mar 2, 2026
Closed
@lhecker lhecker added Area-Input Related to input processing (key presses, mouse, etc.) Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty and removed Needs-Tag-Fix Doesn't match tag requirements labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees

No one assigned

Labels

Area-Input Related to input processing (key presses, mouse, etc.) Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty

Projects

Inbox Servicing Pipeline
Status: To Cherry Pick

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ConPTY: Ask for the cursor position after each resize

3 participants

@lhecker @carlos-zamora @github-advanced-security