Fix abort with nested Tree iteration#984
Merged
Merged
Conversation
Ensure Trees are fully-loaded before creating a TreeIter.
rcoup
added a commit
to koordinates/kart
that referenced
this pull request
Mar 2, 2020
* Swap stdlib Sqlite -> APSW * Pygit2 1.x. Switch to fix for libgit2/pygit2#984 * Fix all the tests
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Mar 10, 2020
1.1.1 (2020-03-06) ------------------------- - Fix crash in tree iteration `#984 <https://github.com/libgit2/pygit2/pull/984>`_ `#980 <https://github.com/libgit2/pygit2/issues/980>`_ - Do not include the docs in dist files, so they're much smaller now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing nested iteration of a Tree, Python crashes with an Abort from a libgit2 assert in
git_tree_entry_byindex().Code to reproduce:
Fix is to ensure
Trees are fully-loaded viaObject__load()before creating aTreeIter, otherwiseself->owner->treeinTreeIter_iternext()can resolve toNULL.