Skip to content

add the attribute to show the number of deltas/patches in one diff#281

Merged
jdavid merged 2 commits into
libgit2:masterfrom
alexband:size
Nov 1, 2013
Merged

add the attribute to show the number of deltas/patches in one diff#281
jdavid merged 2 commits into
libgit2:masterfrom
alexband:size

Conversation

@alexband

Copy link
Copy Markdown

diff.size returns the number of deltas/patches of one diff

@jdavid

jdavid commented Oct 31, 2013

Copy link
Copy Markdown
Member

Since we have an iterator for patch in diff, it would be better to implement the length function, so it reads len(diff)

@jdavid

jdavid commented Oct 31, 2013

Copy link
Copy Markdown
Member

...instead of diff.size

@alexband

alexband commented Nov 1, 2013

Copy link
Copy Markdown
Author

@jdavid yes definitely better, see c0b1ab9

@jdavid jdavid merged commit c0b1ab9 into libgit2:master Nov 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants