utility to test if a commit is a descendent of one or more commits

[chadrik]

Hi,
I'm looking to recreate the behavior of git branch --contains <commit> using pygit2. The core of the routine in git is implemented here and here in is_descendent_of and merge_bases_many. I've looked through the pygit2 source for the building blocks of something similar but couldn't find anything.

A few questions:

• is there something similar to this in pygit2 that I missed?
• if no: is this considered too "high level" for this project?
• if no: would you be interested in a pull request for this feature should I find the time to do it?
• if yes: do you think this would be better implemented in C or python?

thanks!

[jdavid]

I think there's not. Pull request welcome.

https://libgit2.org/libgit2/#HEAD/group/graph/git_graph_descendant_of and https://libgit2.org/libgit2/#HEAD/group/merge/git_merge_base_many are libgit2's equivalent of those two functions, right?

Then wrap both of them and write the rest in Python.

Thanks!

[chadrik]

Sounds easy enough. Thanks for the guidance.

[jdavid]

@chadrik This is done with PR #816 right? Or is there something else to do?

[chadrik]

Yup, all done. Thanks for the quick feedback throughout the process.