Skip to content

ssh: use errors.As for PartialSuccessError unwrapping#352

Open
XananasX7 wants to merge 1 commit into
golang:masterfrom
XananasX7:fix/ssh-banner-partial-success-unwrap
Open

ssh: use errors.As for PartialSuccessError unwrapping#352
XananasX7 wants to merge 1 commit into
golang:masterfrom
XananasX7:fix/ssh-banner-partial-success-unwrap

Conversation

@XananasX7

@XananasX7 XananasX7 commented Jun 3, 2026

Copy link
Copy Markdown

ssh: use errors.As for PartialSuccessError unwrapping

When BannerError wraps a PartialSuccessError, the auth loop
failed to detect it. Use errors.As instead of a type assertion
so that wrapped PartialSuccessError values are recognised.

A new test TestBannerWrappingPartialSuccess is added to verify
the banner is delivered, the client completes the password second
factor, and the connection is established.

Updates golang/go#79809

@google-cla

google-cla Bot commented Jun 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@XananasX7 XananasX7 force-pushed the fix/ssh-banner-partial-success-unwrap branch from 20f739d to 4fe8209 Compare June 13, 2026 16:52
@XananasX7

Copy link
Copy Markdown
Author

Rewrote the commit with mehdiananas007@gmail.com as the author email — this is the address I used to sign the Google CLA. The cla/google check should now pass.

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 4fe8209) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/790420.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/790420.
After addressing review feedback, remember to publish your drafts!

@XananasX7

Copy link
Copy Markdown
Author

Updated the PR description to address the Gerrit bot feedback: removed all Markdown formatting (backticks, bold, code fences), wrapped all lines to ≤76 characters, and added 'Updates golang/go#79809' as the bug reference.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/790420.
After addressing review feedback, remember to publish your drafts!

When BannerError wraps a PartialSuccessError, the auth loop
failed to detect it. Use errors.As instead of a type assertion.

Updates golang/go#79809
@XananasX7 XananasX7 force-pushed the fix/ssh-banner-partial-success-unwrap branch from 4fe8209 to 724988c Compare June 14, 2026 16:34
@XananasX7

Copy link
Copy Markdown
Author

Trimmed the commit message to plain text, ≤76 char lines, no markdown formatting — per Ian Lance Taylor's Gerrit review feedback. The fix itself is unchanged.

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 724988c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/790420.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@XananasX7 XananasX7 changed the title ssh: use errors.As for PartialSuccessError unwrapping in auth loop ssh: use errors.As for PartialSuccessError unwrapping Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants