Skip to content

Travis CI: 'sudo' tag is now deprecated in Travis #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cclauss wants to merge 3 commits into from
Closed

Travis CI: 'sudo' tag is now deprecated in Travis #825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2395d6b
Travis CI: 'sudo' tag is now deprecated in Travis
cclauss Jan 15, 2019
c8e2d12
Force a retest
cclauss Jan 19, 2019
338cffe
dist: xenial for all versions of Python
cclauss Jan 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
language: python
dist: xenial
python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"
# - "pypy" - won't work as smmap doesn't work (see gitdb/.travis.yml for details)
matrix:
matrix:
include:
- python: 3.7
dist: xenial

@jeking3 jeking3 Jan 16, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to move dist: xenial out one level and define it globally. If so, you can move the python declarations out to the global list and eliminate the matrix include section all together.

@cclauss cclauss Jan 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that both solutions work. While xenial is generally available, it is not the Travis default distro so I usually take the more conservative route of only using it where it is needed.

@cclauss cclauss Jan 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#831 eliminates one test when run on xenial so I think it is best to run more tests on Pythons that are compatible with the Travis CI default distro and fewer tests only on Python 3.7 and nightly.

sudo: required
- python: "nightly"
dist: xenial
sudo: required
allow_failures:
- python: "nightly"
git:
Expand Down