Fix platform-specific TCP keep-alive issues#3090
Merged
Merged
Conversation
2. hard-disable TCP keep-alives on DNS endpoints for non-Windows before .NET 10
ndyakov
approved these changes
May 26, 2026
ndyakov
left a comment
ndyakov
left a comment
There was a problem hiding this comment.
Other than the question I added this looks good to me.
uglide
suggested changes
May 26, 2026
…lized; add tcpKeepAlive to docs
…s; they can't run in parallel between runtimes
|
Thank you again for the vast turnaround on this! You rock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3086
before .NET 10, there are problems with TCP keep-alive on DNS endpoint on non-Windows; here we compensate:
(also updates CI image to Redis 8.8)