PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features.#100
Merged
KelSolaar merged 28 commits intoSep 16, 2023
Conversation
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Contributor
Author
|
@doug-walker: I opened a PR (aces-aswf/aces-core#136) to add support for DisplayP3 on the aces-dev side and updated the spreadsheets accordingly. We are missing a Builtin on the OCIO side which is alright but it begs the question as to whether the Builtin should be in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/src/OpenColorIO/transforms/builtins/ACES.cpp or not given the PR is not merged at all, and might not be in time. |
KelSolaar
changed the title
Contributor
Author
|
PR was merged, we can move on! A few notes:
|
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
2 times, most recently
from
d900e5c to
12eabed
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
12eabed to
944cb21
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
944cb21 to
6e6fa88
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
6e6fa88 to
181df7c
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
ecf907b to
dbc462e
Compare
KelSolaar
force-pushed
the
feature/displayp3
branch
from
dbc462e to
2703bcf
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
2703bcf to
3d0f913
Compare
KelSolaar
force-pushed
the
feature/displayp3
branch
4 times, most recently
from
011234a to
f05b3b8
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
f05b3b8 to
ccf11e8
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
e69b829 to
73b2581
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
4 times, most recently
from
69f8d8d to
4c1dd57
Compare
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Contributor
Author
|
Ok this is ready, I verified that the artefacts generated are producing the same files than the builtin configs in 2.3! @michdolan and @doug-walker for VIS! |
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
KelSolaar
force-pushed
the
feature/displayp3
branch
from
4c1dd57 to
39e5e48
Compare
doug-walker
approved these changes
Sep 10, 2023
doug-walker
left a comment
doug-walker
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you Thomas!
| <OutputDescriptor>ACES2065-1</OutputDescriptor> | ||
| <Info> | ||
| <ACEStransformID>urn:ampas:aces:transformId:v1.5:IDT.ARRI.LogC4.a1.v1</ACEStransformID> | ||
| <ACEStransformID>urn:ampas:aces:transformId:v1.5:IDT.ARRI.ARRI-LogC4.a1.v1</ACEStransformID> |
Contributor
There was a problem hiding this comment.
Given that we are modifying the ID submitted by Sean of ARRI, should we do anything to indicate this was to make it agree with what is in aces-dev? Should we get Sean to approve it? Or maybe it's sufficiently obvious that it's just a bug fix and no comment is necessary. Either way is fine with me.
Contributor
Author
There was a problem hiding this comment.
Will add a comment, thank you!
Contributor
Author
There was a problem hiding this comment.
Will add a comment in the release notes as it gives better visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for the remaining DisplayP3 colourspaces and many other features.