suggestion breaks when selecting lines outside of changes #199838
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
Body
vyperlang/vyper#5134 (comment)
Here is what I see:
But the suggestion is between the current code and the desired code, so it should be:
I had to create the sugestion manually (tripple backtick +

suggestion), because the button did not show upThis appears to be because I selected one line which is outside of the current changes (
else:), and is reinforced by the following:(please ignore the indentation mismatch, that is my own mistake, I have since fixed, including in the examples above)
section 1 matches the code which is unchanged by the PR, but still part of the suggested changes
section 2 matches the code from before the PR
section 3 matches the code from the PR
Beta Was this translation helpful? Give feedback.
All reactions