Wire evil-ghostel into byte-compile and lint

`extensions/evil-ghostel/evil-ghostel.el' was never byte-compiled by
`make all' — only `lisp/' files were in $(ELC), and package-lint
only ran on `lisp/ghostel.el'.  MELPA's stricter sandbox caught
warnings ours didn't.

- Add `extensions/evil-ghostel/evil-ghostel.elc' to $(ELC); split
  the pattern rule so `lisp/%.elc' compiles with `-L lisp' as
  before, and `extensions/evil-ghostel/%.elc' compiles with
  `-L $(EVIL_DIR) -L lisp -L extensions/evil-ghostel'.
- Factor the evil clone into an order-only `$(EVIL_DIR)' target
  reused by both the new compile rule and `test-evil'.
- Extend `package-lint' to also lint evil-ghostel.el.
- Add a `docquotes' target mirroring melpazoid's regex check for
  back/front-quoted non-symbols, widened from melpazoid's `[A-Z]+'
  to `[A-Z_]+' so identifiers like INSIDE_EMACS aren't skipped.
  Wire into `lint'.
- Add forward declarations: `evil-ghostel-mode',
  `ghostel--cursor-position', `ghostel--mode-enabled' in
  evil-ghostel.el; `ghostel--alt-screen-p' in ghostel-debug.el.
  Byte-compile now passes cleanly without the native module loaded.
- Strip back/front quotes from env-var and keystroke names in
  docstrings (TERM, INSIDE_EMACS, EMACS_GHOSTEL_PATH, I/A) — those
  aren't top-level elisp symbols.
- Fix a pre-existing parallel race: `test-evil' now depends on
  `build $(ELC)' (matching `test-native').  Without it,
  `make -j4 all' could start `test-evil' before
  `ghostel-module.dylib' existed, causing `void-function
  ghostel--new' failures intermittently.

Author: dakra

Makefile

@@ -5,9 +5,10 @@ MELPAZOID_DIR  ?= $(XDG_CACHE_HOME)/melpazoid
 EVIL_DIR       ?= $(XDG_CACHE_HOME)/evil
 
 ELC := lisp/ghostel.elc lisp/ghostel-debug.elc lisp/ghostel-compile.elc \
-       lisp/ghostel-eshell.elc
+       lisp/ghostel-eshell.elc \
+       extensions/evil-ghostel/evil-ghostel.elc
 
-.PHONY: all build test test-native test-all test-evil lint melpazoid melpazoid-ghostel melpazoid-evil-ghostel byte-compile bench bench-quick clean regen-terminfo
+.PHONY: all build test test-native test-all test-evil lint melpazoid melpazoid-ghostel melpazoid-evil-ghostel byte-compile docquotes bench bench-quick clean regen-terminfo
 
 all: build test-all test-evil lint
 
@@ -18,9 +19,18 @@ build:
 # Make's timestamp tracking keeps the byte-compiled files in sync, so
 # test targets never load stale .elc (Emacs prefers .elc over .el
 # even when the source is newer, which silently masks edits).
-%.elc: %.el
+lisp/%.elc: lisp/%.el
 	$(EMACS) --batch -Q -L lisp --eval "(setq byte-compile-error-on-warn t)" -f batch-byte-compile $<
 
+# Extension packages depend on third-party libraries; reuse the evil
+# checkout that `test-evil' manages.
+$(EVIL_DIR):
+	git clone --depth 1 https://github.com/emacs-evil/evil.git "$@"
+
+extensions/evil-ghostel/%.elc: extensions/evil-ghostel/%.el | $(EVIL_DIR)
+	$(EMACS) --batch -Q -L "$(EVIL_DIR)" -L lisp -L extensions/evil-ghostel \
+		--eval "(setq byte-compile-error-on-warn t)" -f batch-byte-compile $<
+
 test: $(ELC)
 	$(EMACS) --batch -Q -L lisp -l ert -l test/ghostel-test.el -f ghostel-test-run-elisp
 
@@ -29,23 +39,20 @@ test-native: build $(ELC)
 
 test-all: test test-native
 
-test-evil:
-	@if [ ! -d "$(EVIL_DIR)" ]; then \
-		git clone --depth 1 https://github.com/emacs-evil/evil.git "$(EVIL_DIR)"; \
-	fi
+test-evil: build $(ELC) | $(EVIL_DIR)
 	$(EMACS) --batch -Q -L "$(EVIL_DIR)" -L lisp -L extensions/evil-ghostel \
 		-l ert -l test/evil-ghostel-test.el -f evil-ghostel-test-run
 
 byte-compile: $(ELC)
 
-lint: byte-compile package-lint checkdoc
+lint: byte-compile package-lint checkdoc docquotes
 
 package-lint:
 	$(EMACS) --batch -Q \
 		--eval "(package-initialize)" \
 		--eval "(require 'package-lint)" \
 		-f package-lint-batch-and-exit \
-		lisp/ghostel.el
+		lisp/ghostel.el extensions/evil-ghostel/evil-ghostel.el
 
 checkdoc:
 	$(EMACS) --batch -Q \
@@ -64,6 +71,26 @@ checkdoc:
 		        (message \"%s\" (buffer-string))))) \
 		  (unless ok (kill-emacs 1)))"
 
+# Mirrors melpazoid's "Only use back/front quotes to link to top-level
+# elisp symbols" check, widened to also catch identifiers with
+# underscores like INSIDE_EMACS — env-var and macro-style names that
+# melpazoid's stricter [A-Z]+ regex skips.
+docquotes:
+	$(EMACS) --batch -Q \
+		--eval "(let ((ok t)) \
+		  (dolist (f '(\"lisp/ghostel.el\" \"lisp/ghostel-debug.el\" \"lisp/ghostel-compile.el\" \"lisp/ghostel-eshell.el\" \"extensions/evil-ghostel/evil-ghostel.el\")) \
+		    (with-temp-buffer \
+		      (insert-file-contents f) \
+		      (setq case-fold-search nil) \
+		      (goto-char (point-min)) \
+		      (while (re-search-forward \"\`[A-Z_]+'\" nil t) \
+		        (setq ok nil) \
+		        (message \"%s:%d:%d: Only use back/front quotes to link to top-level elisp symbols (%s)\" \
+		                 f (line-number-at-pos) \
+		                 (1+ (- (match-beginning 0) (line-beginning-position))) \
+		                 (match-string 0))))) \
+		  (unless ok (kill-emacs 1)))"
+
 melpazoid: melpazoid-ghostel melpazoid-evil-ghostel
 
 melpazoid-ghostel:

extensions/evil-ghostel/evil-ghostel.el

@@ -27,6 +27,11 @@
 (require 'evil)
 (require 'ghostel)
 
+(declare-function ghostel--cursor-position "ghostel-module")
+(declare-function ghostel--mode-enabled "ghostel-module")
+
+(defvar evil-ghostel-mode)
+
 ;; ---------------------------------------------------------------------------
 ;; Customization
 ;; ---------------------------------------------------------------------------
@@ -160,7 +165,7 @@ In alt-screen mode, defer to the terminal's cursor style."
 
 (defvar evil-ghostel--sync-inhibit nil
   "When non-nil, skip arrow-key sync in the insert-state-entry hook.
-Set by the `I'https://github.com/`A' advice which send Home/End directly.")
+Set by the I/A advice which send Home/End directly.")
 
 (defun evil-ghostel--insert-state-entry ()
   "Sync terminal cursor to Emacs point when entering `emacs-state'.

lisp/ghostel-debug.el

@@ -33,8 +33,9 @@
 (require 'lisp-mnt)
 (require 'ghostel)
 
-(declare-function ghostel--module-version "ghostel-module")
+(declare-function ghostel--alt-screen-p "ghostel-module")
 (declare-function ghostel--mode-enabled "ghostel-module")
+(declare-function ghostel--module-version "ghostel-module")
 
 (defvar ghostel-debug--log-buffer nil
   "Buffer used for ghostel debug logging.")

lisp/ghostel.el

@@ -131,19 +131,19 @@ A list of \"KEY=VALUE\" strings, prepended to `process-environment'
 before spawning the shell.  A bare \"KEY\" (no `=') unsets the variable.
 
 For local spawns, entries here take precedence over ghostel's own
-variables (`TERM', `INSIDE_EMACS', `EMACS_GHOSTEL_PATH',
-shell-integration vars), so a user who sets `TERM' here wins — which
+variables (TERM, INSIDE_EMACS, EMACS_GHOSTEL_PATH,
+shell-integration vars), so a user who sets TERM here wins — which
 will also disable ghostel's shell integration if the chosen TERM
 breaks its assumptions.
 
 Also honored via `dir-locals.el' for per-project overrides.
 
 TRAMP caveats:
 - Entries with `=' are propagated to the remote shell.
-- `TERM' is always reset by TRAMP to `tramp-terminal-type' (see
+- TERM is always reset by TRAMP to `tramp-terminal-type' (see
   `tramp-handle-make-process'); overrides in `ghostel-environment'
   do not win remotely.
-- `INSIDE_EMACS' is rewritten by TRAMP via `tramp-inside-emacs',
+- INSIDE_EMACS is rewritten by TRAMP via `tramp-inside-emacs',
   which appends `,tramp:VER' to whatever value is in scope.  For
   ghostel that means the remote shell sees `ghostel,tramp:VER'
   rather than the bare `ghostel' set locally — the leading